Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xpack_main as a dependency in alerting test fixture plugins #55602

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Add xpack_main as a dependency in alerting test fixture plugins #55602

merged 1 commit into from
Jan 22, 2020

Conversation

mikecote
Copy link
Contributor

CI has been receiving a race condition error after merging new platform work (#55026). This PR makes plugins that use registerFeature function have xpack_main as a dependency.

14:24:26       │ proc [kibana]   log   [18:24:24.034] [fatal][root] TypeError: Cannot read property 'registerFeature' of undefined
14:24:26       │ proc [kibana]     at Plugin.init [as externalInit] (/dev/shm/workspace/kibana/x-pack/test/alerting_api_integration/common/fixtures/plugins/actions/index.ts:53:33)
14:24:26       │ proc [kibana]     at Object.register (/dev/shm/workspace/install/kibana-2/src/legacy/server/plugins/lib/plugin.js:96:20)
14:24:26       │ proc [kibana]     at internals.Server.register (/dev/shm/workspace/install/kibana-2/node_modules/hapi/lib/server.js:431:35)
14:24:26       │ proc [kibana]     at Plugin.init (/dev/shm/workspace/install/kibana-2/src/legacy/server/plugins/lib/plugin.js:100:28)
14:24:26       │ proc [kibana]     at Plugin.init (/dev/shm/workspace/install/kibana-2/node_modules/lodash/index.js:7411:25)
14:24:26       │ proc [kibana]     at callPluginHook (/dev/shm/workspace/install/kibana-2/src/legacy/server/plugins/lib/call_plugin_hook.js:53:25)

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jan 22, 2020
@mikecote mikecote self-assigned this Jan 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor Author

cc @gmmorris fyi. Not directly related I believe. Maybe coincidence.

pmuellr
pmuellr approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote merged commit 2e6f821 into elastic:master Jan 22, 2020
@mikecote mikecote mentioned this pull request Jan 22, 2020
Merged
mikecote added a commit to mikecote/kibana that referenced this pull request Jan 22, 2020
@mikecote
Add xpack_main as a dependency in a few tests (elastic#55602)
bec322b
mikecote added a commit that referenced this pull request Jan 22, 2020
@mikecote
Add xpack_main as a dependency in a few tests (#55602) (#55610)
ce1e024
mikecote added a commit to mikecote/kibana that referenced this pull request Jan 24, 2020
@mikecote
Add xpack_main as a dependency in a few tests (elastic#55602)
1706b2d
@mikecote mikecote mentioned this pull request Jan 24, 2020
Merged
mikecote added a commit that referenced this pull request Jan 24, 2020
@mikecote
Add xpack_main as a dependency in a few tests (#55602) (#55847)
9c0bb0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

Assignees

@mikecote mikecote

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikecote @elasticmachine @kibanamachine @pmuellr